Conversation
rymurr
force-pushed
the
spark-extension
branch
2 times, most recently
from
d266afb to
0c1e118
Compare
rymurr
force-pushed
the
spark-extension
branch
3 times, most recently
from
39fede1 to
16bfc0a
Compare
snazy
reviewed
Jun 17, 2021
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Did a first pass on this one and left some comments.
...sions/src/main/antlr4/org.apache.spark.sql.catalyst.parser.extensions/NessieSqlExtensions.g4
Outdated
Show resolved
Hide resolved
...sions/src/main/antlr4/org.apache.spark.sql.catalyst.parser.extensions/NessieSqlExtensions.g4
Outdated
Show resolved
Hide resolved
| ; | ||
|
|
||
| statement | ||
| : CREATE (BRANCH|TAG) identifier (IN catalog=identifier)? (AS reference=identifier)? #nessieCreateRef |
Member
There was a problem hiding this comment.
I'd prefer to distinguish between named-reference-identifiers and pure-hash-refs and references that can be either.
The current syntax allows something like CREATE BRANCH 012345, which feels a bit odd (like named-refs that can start with a digit).
Member
There was a problem hiding this comment.
Same for identifier (allows a leading digit) used for catalog names.
Contributor
Author
There was a problem hiding this comment.
Im not sure what you mean. Do you mean validate w/ ANTLR that identifier is a valid reference?
We allow leading digits for branch names don't we? Spark definitely allows it for catalogs
...rg-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/NessieUtils.scala
Outdated
Show resolved
Hide resolved
...rg-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/NessieUtils.scala
Outdated
Show resolved
Hide resolved
...tensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/UseReferenceExec.scala
Outdated
Show resolved
Hide resolved
...n/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSparkSqlExtensionsParser.scala
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensionsAstBuilder.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensionsAstBuilder.scala
Outdated
Show resolved
Hide resolved
clients/deltalake/core/src/main/scala/org/projectnessie/deltalake/NessieLogStore.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1373 +/- ##
============================================
- Coverage 78.83% 75.64% -3.19%
- Complexity 2049 2067 +18
============================================
Files 259 281 +22
Lines 12023 12646 +623
Branches 962 1003 +41
============================================
+ Hits 9478 9566 +88
- Misses 2074 2599 +525
- Partials 471 481 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
Note: something is going on w/ jacoco where all of the code in this PR is showing 0% coverage. Even though there is 100%. Getting: Possibly because of the shaded jar? Or maybe its scala? |
nastra
reviewed
Jun 18, 2021
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
overall LGTM, just a few small things
...in/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensionsAstBuilder.scala
Outdated
Show resolved
Hide resolved
...nsions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/CreateReferenceField.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensionsAstBuilder.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/catalyst/parser/extensions/NessieSqlExtensionsAstBuilder.scala
Outdated
Show resolved
Hide resolved
...rg-extensions/src/main/scala/org/apache/spark/sql/execution/datasources/v2/NessieUtils.scala
Outdated
Show resolved
Hide resolved
| .getCommitLogStream( | ||
| nessieClient.getTreeApi, | ||
| branch, | ||
| CommitLogParams.empty() |
Contributor
There was a problem hiding this comment.
can we use CommitLogParams.builder().before(..).after(..).build() for now?
.../iceberg-extensions/src/test/java/org/projectnessie/spark/extensions/ITNessieStatements.java
Outdated
Show resolved
Hide resolved
.../iceberg-extensions/src/test/java/org/projectnessie/spark/extensions/ITNessieStatements.java
Outdated
Show resolved
Hide resolved
.../iceberg-extensions/src/test/java/org/projectnessie/spark/extensions/ITNessieStatements.java
Outdated
Show resolved
Hide resolved
.../iceberg-extensions/src/test/java/org/projectnessie/spark/extensions/ITNessieStatements.java
Outdated
Show resolved
Hide resolved
added 5 commits
June 28, 2021 14:14
TODO * clean up todos * add features to NessieCatalog in iceberg * unit tests * refactor and clean code * update demo
Contributor
Author
nastra
reviewed
Jun 29, 2021
...ts/spark-extensions/src/test/java/org/projectnessie/spark/extensions/ITNessieStatements.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Addressed all of your comments @nastra. Hopefully looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long way to go yet but this is an initial implementation of SQL commands
TODO
This change is